refactor(test): share browser and apktool fixture lifecycles
This commit is contained in:
1 parent
1bb2fa23de
commit
7dd6941393
9 files changed
+461
-647
No files matched your search
@@ -1,6 +1,6 @@
|
||||
import { expect, it } from "vitest";
|
||||
import { createWebPageInspection } from "../../tests/support/browser/webPageInspection.js";
|
||||
|
||||
import { webPageInspectionSchema } from "../domain/browserObservationSchemas.js";
|
||||
import {
|
||||
AnalysisCancelledError,
|
||||
AnalysisOutputError,
|
||||
@@ -13,7 +13,6 @@ import type {
|
||||
} from "../domain/webBundleAnalysis.js";
|
||||
import { analyzeWebBundleInputSchema } from "../domain/webBundleAnalysis.js";
|
||||
import { analyzeCapturedWebScript } from "../domain/webBundleAnalyzer.js";
|
||||
import { createWebTextArtifact } from "../domain/webContentArtifact.js";
|
||||
import { ProviderCleanupError } from "../domain/providerCleanupError.js";
|
||||
import { err, ok } from "../domain/result.js";
|
||||
import {
|
||||
@@ -373,107 +372,12 @@ const deferred = <T>(): {
|
||||
};
|
||||
|
||||
const inspection = (sources: readonly string[]) =>
|
||||
webPageInspectionSchema.parse({
|
||||
browser: {
|
||||
product: "Fake Chrome",
|
||||
protocol_version: "1.3",
|
||||
revision: "1",
|
||||
user_agent: "fake",
|
||||
js_version: "1",
|
||||
},
|
||||
target: {
|
||||
target_id: "page-1",
|
||||
type: "page",
|
||||
title: "App",
|
||||
url: `${origin}/app`,
|
||||
createWebPageInspection(
|
||||
sources.map((source, index) => ({
|
||||
source,
|
||||
scriptKey: `scr_${String(index + 1).repeat(64)}`,
|
||||
url: `${origin}/assets/${String(index)}.js`,
|
||||
origin,
|
||||
attached: false,
|
||||
},
|
||||
capture_window: {
|
||||
started_at: "2026-07-14T00:00:00.000Z",
|
||||
ended_at: "2026-07-14T00:00:01.000Z",
|
||||
observation_ms: 1_000,
|
||||
},
|
||||
completeness: {
|
||||
status: "attach_limited",
|
||||
conditions: ["attach_limited"],
|
||||
policy_filtered_sections: [],
|
||||
attach_limited_sections: ["network_requests"],
|
||||
truncated_sections: [],
|
||||
unavailable_sections: [],
|
||||
excluded: [],
|
||||
dropped_events: {
|
||||
scripts: 0,
|
||||
network_requests: 0,
|
||||
console_events: 0,
|
||||
websocket_connections: 0,
|
||||
websocket_frames: 0,
|
||||
webmcp_tools: 0,
|
||||
timeline_events: 0,
|
||||
total: 0,
|
||||
},
|
||||
},
|
||||
frames: [],
|
||||
dom: { total_nodes: 0, nodes: [] },
|
||||
accessibility: {
|
||||
total_nodes: 0,
|
||||
text_capture: {
|
||||
status: "not_approved",
|
||||
retained_bytes: 0,
|
||||
excluded_fields: 0,
|
||||
},
|
||||
nodes: [],
|
||||
},
|
||||
scripts: {
|
||||
total: sources.length,
|
||||
items: sources.map((source, index) => ({
|
||||
script_key: `scr_${String(index + 1).repeat(64)}`,
|
||||
url: `${origin}/assets/${String(index)}.js`,
|
||||
origin,
|
||||
cdp_hash: `hash-${String(index)}`,
|
||||
length: Buffer.byteLength(source),
|
||||
is_module: true,
|
||||
language: "JavaScript",
|
||||
source_map_url: null,
|
||||
resource_reconciliation: {
|
||||
status: "unmatched",
|
||||
reason: "no_exact_sanitized_url",
|
||||
},
|
||||
source: {
|
||||
included: true,
|
||||
artifact: createWebTextArtifact(source, "text/javascript"),
|
||||
},
|
||||
})),
|
||||
},
|
||||
resources: [],
|
||||
network: {
|
||||
requests: [],
|
||||
websocket_connections: [],
|
||||
coverage_started_at: "2026-07-14T00:00:00.000Z",
|
||||
prior_activity_available: false,
|
||||
},
|
||||
console: {
|
||||
events: [],
|
||||
coverage_started_at: "2026-07-14T00:00:00.000Z",
|
||||
prior_activity_available: false,
|
||||
},
|
||||
workers: [],
|
||||
metadata: {
|
||||
responses: [],
|
||||
dom_urls: [],
|
||||
agent_hints: [],
|
||||
excluded_dom_urls: 0,
|
||||
headers_allowlisted: true,
|
||||
},
|
||||
storage: {
|
||||
origin,
|
||||
usage_bytes: null,
|
||||
quota_bytes: null,
|
||||
local_storage_keys: [],
|
||||
session_storage_keys: [],
|
||||
indexed_db_names: [],
|
||||
cache_names: [],
|
||||
values_redacted: true,
|
||||
},
|
||||
limitations: [],
|
||||
});
|
||||
cdpHash: `hash-${String(index)}`,
|
||||
})),
|
||||
);
|
||||
@@ -216,6 +216,51 @@ const policyResponse = (method: string): unknown =>
|
||||
? { result: { value: null } }
|
||||
: {};
|
||||
|
||||
const prepareLateStopRetry = async () => {
|
||||
const { cleanup, page, storage } = fixture();
|
||||
const cancellation = new AbortController();
|
||||
storage?.close.mockResolvedValue({ loadingStopped: false });
|
||||
const attached = connectedScenario("block");
|
||||
const session = await PlaywrightScenarioSession.open(
|
||||
attached,
|
||||
{},
|
||||
{ signal: cancellation.signal },
|
||||
);
|
||||
const { promise: held, resolve: finishRestoration } = deferred();
|
||||
const { promise: started, resolve: restorationStarted } = deferred();
|
||||
const { promise: transportClosed, resolve: signalTransportClosed } =
|
||||
deferred();
|
||||
mocks.policyTransportClose.mockImplementation(async () => {
|
||||
signalTransportClosed();
|
||||
});
|
||||
mocks.policySend.mockImplementation(async (method: string) => {
|
||||
if (method === "Runtime.evaluate") {
|
||||
restorationStarted();
|
||||
await held;
|
||||
}
|
||||
return policyResponse(method);
|
||||
});
|
||||
|
||||
vi.useFakeTimers();
|
||||
try {
|
||||
const firstClose = session.close(false).then(
|
||||
() => ({ ok: true as const }),
|
||||
(cause: unknown) => ({ ok: false as const, cause }),
|
||||
);
|
||||
await started;
|
||||
await vi.advanceTimersByTimeAsync(5_001);
|
||||
await expect(firstClose).resolves.toMatchObject({ ok: false });
|
||||
finishRestoration();
|
||||
await transportClosed;
|
||||
await vi.advanceTimersByTimeAsync(0);
|
||||
cancellation.abort();
|
||||
return { cleanup, page, session };
|
||||
} catch (cause) {
|
||||
vi.useRealTimers();
|
||||
throw cause;
|
||||
}
|
||||
};
|
||||
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks();
|
||||
mocks.policySend.mockReset();
|
||||
@@ -661,44 +706,8 @@ it("retries a failed connected-page stop when service workers are allowed", asyn
|
||||
});
|
||||
|
||||
it("retains a late fallback stop failure for retry", async () => {
|
||||
const { cleanup, page, storage } = fixture();
|
||||
const cancellation = new AbortController();
|
||||
storage?.close.mockResolvedValue({ loadingStopped: false });
|
||||
const attached = connectedScenario("block");
|
||||
const session = await PlaywrightScenarioSession.open(
|
||||
attached,
|
||||
{},
|
||||
{ signal: cancellation.signal },
|
||||
);
|
||||
const { promise: held, resolve: finishRestoration } = deferred();
|
||||
const { promise: started, resolve: restorationStarted } = deferred();
|
||||
const { promise: transportClosed, resolve: signalTransportClosed } =
|
||||
deferred();
|
||||
mocks.policyTransportClose.mockImplementation(async () => {
|
||||
signalTransportClosed();
|
||||
});
|
||||
mocks.policySend.mockImplementation(async (method: string) => {
|
||||
if (method === "Runtime.evaluate") {
|
||||
restorationStarted();
|
||||
await held;
|
||||
}
|
||||
return policyResponse(method);
|
||||
});
|
||||
|
||||
vi.useFakeTimers();
|
||||
const { cleanup, page, session } = await prepareLateStopRetry();
|
||||
try {
|
||||
const firstClose = session.close(false).then(
|
||||
() => ({ ok: true as const }),
|
||||
(cause: unknown) => ({ ok: false as const, cause }),
|
||||
);
|
||||
await started;
|
||||
await vi.advanceTimersByTimeAsync(5_001);
|
||||
await expect(firstClose).resolves.toMatchObject({ ok: false });
|
||||
finishRestoration();
|
||||
await transportClosed;
|
||||
await vi.advanceTimersByTimeAsync(0);
|
||||
|
||||
cancellation.abort();
|
||||
const stopFailure = new Error("late main-frame stop failed");
|
||||
const detachedFrame = {
|
||||
evaluate: vi.fn(async () => {
|
||||
@@ -734,44 +743,8 @@ it("retains a late fallback stop failure for retry", async () => {
|
||||
});
|
||||
|
||||
it("coalesces concurrent late-stop close retries", async () => {
|
||||
const { cleanup, page, storage } = fixture();
|
||||
const cancellation = new AbortController();
|
||||
storage?.close.mockResolvedValue({ loadingStopped: false });
|
||||
const attached = connectedScenario("block");
|
||||
const session = await PlaywrightScenarioSession.open(
|
||||
attached,
|
||||
{},
|
||||
{ signal: cancellation.signal },
|
||||
);
|
||||
const { promise: held, resolve: finishRestoration } = deferred();
|
||||
const { promise: started, resolve: restorationStarted } = deferred();
|
||||
const { promise: transportClosed, resolve: signalTransportClosed } =
|
||||
deferred();
|
||||
mocks.policyTransportClose.mockImplementation(async () => {
|
||||
signalTransportClosed();
|
||||
});
|
||||
mocks.policySend.mockImplementation(async (method: string) => {
|
||||
if (method === "Runtime.evaluate") {
|
||||
restorationStarted();
|
||||
await held;
|
||||
}
|
||||
return policyResponse(method);
|
||||
});
|
||||
|
||||
vi.useFakeTimers();
|
||||
const { cleanup, page, session } = await prepareLateStopRetry();
|
||||
try {
|
||||
const firstClose = session.close(false).then(
|
||||
() => ({ ok: true as const }),
|
||||
(cause: unknown) => ({ ok: false as const, cause }),
|
||||
);
|
||||
await started;
|
||||
await vi.advanceTimersByTimeAsync(5_001);
|
||||
await expect(firstClose).resolves.toMatchObject({ ok: false });
|
||||
finishRestoration();
|
||||
await transportClosed;
|
||||
await vi.advanceTimersByTimeAsync(0);
|
||||
|
||||
cancellation.abort();
|
||||
const { promise: heldStop, resolve: finishStop } = deferred();
|
||||
const { promise: startedStop, resolve: stopStarted } = deferred();
|
||||
page.evaluate.mockImplementation(async (script: unknown) => {
|
||||
|
||||
Reference in new issue
Block a user