fix(doctor): require an executable Hopper launcher

This commit is contained in:
morluto committed 2026-07-12 08:56:02 +08:00
1 parent a67054f815
commit aee9cb8e4e
2 files changed
+28 -4

No files matched your search

+10 -1
View File
@@ -26,6 +26,7 @@ export interface DoctorHost {
readonly configuredHopperPath?: string;
macosVersion(): Promise<string | undefined>;
readable(path: string): Promise<boolean>;
executable(path: string): Promise<boolean>;
brewHopperPath(): Promise<string | undefined>;
manualHopperPaths(): Promise<readonly string[]>;
}
@@ -72,7 +73,7 @@ export const runDoctor = async (
].filter((value): value is string => value !== undefined);
let hopperPath: string | undefined;
for (const candidate of new Set(candidates))
if (await host.readable(candidate)) {
if (await host.executable(candidate)) {
hopperPath = candidate;
break;
}
@@ -124,6 +125,14 @@ export const systemDoctorHost = (): DoctorHost => ({
return false;
}
},
async executable(path) {
try {
await access(path, constants.X_OK);
return true;
} catch {
return false;
}
},
async brewHopperPath() {
return probeHomebrew(async (command) => {
try {