Files
rea/tests/fixtures/environmentStateLaterReads.ts
40b9c03f99 feat(environment): serve query numbers, counted values and made objects (#7332)
* feat(environment): serve the writes callers make without recorded form fields

- A create member a recording sent empty ("", null, false, [] or {}) is no
  longer required; a call that leaves it out is applied as sending that value
  (body.blank).
- List views render envelope members that list the listed entities' ids
  (Paperless's `all`), so creates in such collections are confirmed.
- Updates move their entity in collections kept sorted by a field they write,
  and a failed whole-collection read after an update can teach that order.
- A later create that stores an unruled field otherwise is withheld at the
  create, and an item read may fill values a create's answer had not loaded.
- An unsent field respelled between null, [] and {} is unchanged.
- The skill asks for one create with every field and one with only what a
  person must give.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* docs(skill): show how to read signed-in pages before recording

Agents guessed capture keys (artifacts, dom, final) to see pages behind
sign-in, which inspect_web_page cannot reach.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* fix(environment): accept every empty spelling recorded creates sent

A create that fills only what a person must give sends `null` where the
full create sent a string, and `null` or `false` for the same flag. The
merged plan now accepts each recorded empty value, and a call that leaves
the member out is applied as the earliest call sent it.

Also adds the spec folder for this change.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* docs(skill): keep the vary-fields step neutral on UI or API writes

Agents read "the form" as a cue to write through the UI, where some
applications' request bodies are not exposed; a body-unusable UI write
now re-records once with request steps.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* docs(environment): record verification for blank members and sorted writes

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* fix(environment): address review of blank members and sorted writes

- Bulk updates move their entities in turn against the others' earlier
  values and install the final order once, as replay does.
- A member's recorded empty values stay accepted once a later call teaches
  its default; a left-out member with a default keeps the default.
- Write answers spell empty lists and maps as their recorded answers did.
- A rename can teach a sort when the creates chose one by a field the
  update did not write, such as ids that ascend with titles.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* feat(environment): serve the writes that later reads explain

- An item read whose object is marked deleted (deleted, isDeleted or
  is_deleted true) agrees with an absent entity, as EspoCRM answers a
  deleted record; such an object never seeds or adopts an entity.
- maxSize, max_results and maxResults are page sizes, for whole-collection
  list lines and the list query's limit role.
- An item view also shows the fields only reads after its type's first write
  show, when no initial entity holds them (Vikunja's task subscription),
  without requiring them; write answers leave such a field out for entities
  without it, and it no longer withholds the write as incomplete-entities.
- The skill asks updates to change the fields a person would change, and
  expects a deleted object to read back as 404 or marked deleted.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* fix(environment): answer sent empty members as sent, and keep a placed create's order

- A write answer spells an empty list or map the call did not send as its
  recorded answer did; one the call sent is answered as sent, so a create
  sending `[]` is not answered `null` because the first recorded create was.
- A read listing the whole collection that placed a create leaves the create
  only the sorted inserts whose order that read follows, so a later rename
  cannot teach a sort an earlier read ruled out.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* fix(environment): answer bulk updates without fields only later reads show

A bulk update's answer renders each entity with the same allowance a single
update's answer has: a field only reads after the type's first write showed,
which no initial entity holds, is left out for an entity without it, so a
bulk update of a seeded task is no longer refused for lacking it.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* docs(environment): correct how the EspoCRM contact update task passes

The agent trajectories show gpt-oss passes it by creating a replacement contact
and deleting the original, since the served update refuses emailAddress; the
update itself is refused in both builds.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* fix(environment): answer a read of a served-deleted entity marked deleted

An application that soft-deletes still answers a deleted record by id, marked
deleted. Serving now keeps an entity a served delete removed from a type whose
recorded item reads show that, until a reset or load and within the size
data/add loads, and answers a read of it with its last fields and the flag
true, instead of refusing the read.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* fix(environment): keep unloaded create answers, check bulk answers with sent members, narrow inserts only on collection-order reads

- A create whose item read loaded values its answer had not records them
  (`observation.read.unloaded`), and a served create's answer keeps them as
  the recorded answer showed them, a zero-time owner included, while the state
  holds the read's.
- Replay checks a bulk update's recorded answers with each target's sent
  members, as serving answers them, so echoed `null` and `[]` no longer make
  the plan body-unusable.
- A whole-collection read whose query sorts it shows the query's order, so it
  no longer narrows a create's sorted insert candidates.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* docs(environment): record the census with main's unknown-clock rule merged

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* feat(environment): serve query numbers, counted values and made objects

- A query parameter accepts a number or boolean, which serving sends as its
  JSON text, as agents send page sizes and flags.
- A sequence may start at the value its first create took above every value
  its type held (Vikunja's per-project task index), and a later create's
  composed, template or started-sequence rule is adopted when it also spells
  the first create's value.
- A made-object rule explains an object the application makes with each
  created entity: members the request stamped, members holding the entity's
  own id, and counts one past the held objects' values.
- A create's answer names the id of the one object a one-element array member
  holds, so bulk creates link to their type.
- The skill reads each listed object by id before writing.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* feat(environment): let a linked create take path values it stores

A create linked to its type's own collection, whose path has no parameters,
accepts any path values when its plan stores each one in a field, as a Vikunja
task stores its project; replay and serving apply it alike.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* fix(environment): learn a sort from a rename only when moving its entities reaches it

Serving moves only the entities a write changes in a collection kept sorted,
so replay now tries a sort after a rename only when the entities no write the
read exercised changed already follow it. Seeded folders listed out of title
order no longer teach a title sort that serving would answer with another
order.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* fix(environment): keep unloaded create answers a sent value did not echo, and learn no sort from query-sorted reads

- A served create keeps a value its recorded answer had not loaded unless the
  call sent that member and the plan stores it as sent, so a create sending
  `active: false` is answered `false` as recorded while the state holds the
  read's `true`.
- A rename no longer teaches a sort from a whole-collection read its query
  sorts, whose ties need not follow the collection's own order.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* docs(environment): verify query values, counted values and made objects

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* fix(environment): learn the soft-delete flag in the state view and serve by it

Extraction now records the member later item reads set true on a record the
application soft-deleted, and the item view carries it as `deleted_flag`.
Serving reads that fact instead of scanning recorded bodies itself, so one
owner decides what a soft delete looks like.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* docs(environment): record the call-values checks at #7274 93821024

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* fix(environment): learn the soft-delete flag from item reads with a query too

A client may read a deleted record back only with a query, such as a
cache-busting parameter. Every successful read of the item tool now shows the
flag; only plain later reads still add fields.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* docs(environment): record the call-values checks at #7274 45832406

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* fix(environment): learn sorts only from orders a list read confirmed

- A sort retry after a failed whole-collection read requires the entities no
  write changed since a list last showed them to follow it already, rather than
  excusing every entity the update's tool ever wrote: an earlier rename a list
  confirmed in place stays where it was.
- An update takes its creates' sort only from a create a list read showed
  placed; replay still tries a sort a create guessed from the initial order.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* fix(environment): drop entities read back as deleted and answer soft deletes as deleted

- A held entity a later read shows marked deleted is dropped, not adopted with
  the marked object's fields.
- Bulk-update replay renders answers with the optional and later-only fields
  serving uses, so a bulk update of created and seeded entities replays.
- A served delete of a soft-deleting type answers with the entity marked
  deleted, single and bulk.
- A deleted flag only query reads showed is a field of the item view, so a
  served tombstone keeps it where live records omit it.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* fix(environment): check made objects as recorded and keep their ids and clocks honest

- A made object's clock counts as a write clock, so a capture with no clock
  anchor withholds the create instead of stamping 1970.
- Members holding the entity's identity follow the id written, generated or
  sent, through the type's id field.
- A later create's made object is checked as recorded, before its own members
  are rewritten, so one naming another entity withholds the plan.
- A later create's template is adopted only when it spells that create's value
  too, not just when the first create's text holds its source value.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* fix(environment): move updated entities only by placed sorts and keep query-sorted reads from confirming order

Replay moved an updated entity by a sort a create only guessed, while the
update plan exported only placed sorts, so a read could confirm an update
by a move serving would not make. Both now use the placed sort. A passing
list read clears its entities from the moved set only when the state
decides the order of every entity it lists, so a read whose query sorts
it no longer hides an earlier move from a later sort check.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* docs(environment): count six withheld plans that explain more, not seven

The bulk task create counted among them is served on this branch.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* fix(environment): try a learned sort by moving each pending write in turn, as serving does

#retrySort sorted the whole collection, which a list could match while
serving, moving each renamed entity in turn against the others' values
before their own writes, gave another order. The state now records the
values each write replaced, and the retry replays the writes since a
list in collection order last showed their entities.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* fix(environment): answer a served delete with the deleted flag its recorded answer showed

An application may answer a delete with the record as it was and mark it
deleted only on later reads. Delete answers, single and bulk, now take
the flag's value from the recorded answer; reads of a served-deleted
entity still show it marked deleted.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* chore(environment): set aside two hunks next to lines main's saved-values change rewrites

Main's #7267 changes the lines beside the blank-member docs and the
empty-spelling check in explainUpdate. Setting them aside lets that merge
apply cleanly; the commit after it puts them back on top of main's text.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* chore(environment): restore the set-aside hunks on main and bump the skill to 51

Puts the blank-member docs and the empty-spelling check back beside main's
slug and composed text and heldSlugRule. Main is at skill 50 with
different text, so this branch's skill changes take 51.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* chore(environment): bump the skill to 52 above #7260's 51

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* chore(environment): put back the call-values hunks main's merge took its side for, and bump the skill to 53

The merge of main kept main's side where it overlapped this branch, so it
could commit without a conflict. This restores this branch's side next to
main's: made-object agreement beside the & slug spellings, sequence starts
in the earlier evidence (now built by earlierOf), the combined value
imports, and recording step 2 beside main's UI-first step 3. Main is at
skill 50 and #7274 at 52, so this branch takes 53.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* fix(environment): keep sorts a list showed in place ruled out, and created answers' nested members as recorded

A whole list in collection order that showed a renamed entity where a
sort by the renamed field would have moved it now rules that sort out, so
a later rename of the same entity cannot teach it. A create's answer
leaves out members its item read added inside an object the answer
showed, as the recorded answer did; the state still stores them.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* fix(environment): keep a later create's made object only with clocks its request stamped

followsMadeObjects only checked that a made object's clocks parsed, so a
later create whose object showed an older clock still passed, while serving
stamps the write's clock. Its clocks must now be in the rule's format and
within the stamp window of that create's request.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* fix(environment): compare soft-deleted read fields

* fix(environment): reject contradictory learned sequences

* fix(environment): preserve initially deleted item observations

* fix(environment): index stored deleted entities separately

* fix(environment): replay lists that include deleted records

* fix(environment): make no count of a made-object member earlier creates held alike

A count only a later create shows starts at the exemplar's value, which is
right only while the exemplar is the one create accepted: creates accepted
after it showed the member unchanged, which a count would have moved. The
merge now refuses such a count, as the top-level sequence check does.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

---------

Co-authored-by: Claude Opus 5.5 <[email protected]>
Co-authored-by: morluto <[email protected]>
2026-10-28 07:51:03 +08:00

247 lines
9.2 KiB
TypeScript

import type { JsonValue } from "../../src/domain/jsonValue.js";
import type { TimedCaptureRow } from "./analysisView.js";
type Entity = Record<string, JsonValue>;
const contact = (id: number, name: string): Entity => ({
id,
name,
deleted: false,
});
const page = (list: readonly Entity[]): Entity => ({
total: list.length,
list: [...list],
});
const ADA = contact(1, "Ada Finch");
const MINA = contact(2, "Mina Okafor");
const RUI = contact(3, "Rui Castellanos");
/** An initial trash-style list includes an entity already marked deleted. */
export const INITIAL_TRASH_ROWS: readonly TimedCaptureRow[] = [
[
"GET",
"/api/contacts?maxSize=20&offset=0",
page([ADA, MINA, { ...RUI, deleted: true }]),
],
["GET", "/api/contacts/1", ADA],
["GET", "/api/contacts/2", MINA],
["GET", "/api/contacts/3", { ...RUI, deleted: true }],
];
/** A contact deleted, then read by id as EspoCRM answers for soft-deleted records: still found, marked `deleted`. */
export const SOFT_DELETED_ROWS: readonly TimedCaptureRow[] = [
["GET", "/api/contacts?maxSize=20&offset=0", page([ADA, MINA, RUI])],
["GET", "/api/contacts/1", ADA],
["GET", "/api/contacts/2", MINA],
["GET", "/api/contacts/3", RUI],
["DELETE", "/api/contacts/2", true],
["GET", "/api/contacts/2", { ...MINA, deleted: true }],
["DELETE", "/api/contacts/3", true],
["GET", "/api/contacts/3", { ...RUI, deleted: true }],
];
/** Contacts deleted by calls that answer with the record already marked deleted, read back so too. */
export const SOFT_DELETED_ANSWER_ROWS: readonly TimedCaptureRow[] = [
["GET", "/api/contacts?maxSize=20&offset=0", page([ADA, MINA, RUI])],
["GET", "/api/contacts/1", ADA],
["GET", "/api/contacts/2", MINA],
["GET", "/api/contacts/3", RUI],
["DELETE", "/api/contacts/2", { ...MINA, deleted: true }],
["GET", "/api/contacts/2", { ...MINA, deleted: true }],
["DELETE", "/api/contacts/3", { ...RUI, deleted: true }],
["GET", "/api/contacts/3", { ...RUI, deleted: true }],
];
/** Contacts deleted by calls that answer with the record as it was, then read back marked deleted. */
export const STALE_DELETE_ANSWER_ROWS: readonly TimedCaptureRow[] = [
["GET", "/api/contacts?maxSize=20&offset=0", page([ADA, MINA, RUI])],
["GET", "/api/contacts/1", ADA],
["GET", "/api/contacts/2", MINA],
["GET", "/api/contacts/3", RUI],
["DELETE", "/api/contacts/2", MINA],
["GET", "/api/contacts/2", { ...MINA, deleted: true }],
["DELETE", "/api/contacts/3", RUI],
["GET", "/api/contacts/3", { ...RUI, deleted: true }],
];
/** Contacts removed by one bulk call that answers them as they were, then read back marked deleted. */
export const STALE_BULK_DELETE_ROWS: readonly TimedCaptureRow[] = [
["GET", "/api/contacts?maxSize=20&offset=0", page([ADA, MINA, RUI])],
["GET", "/api/contacts/1", ADA],
["GET", "/api/contacts/2", MINA],
["GET", "/api/contacts/3", RUI],
["DELETE", "/api/contacts", [MINA, RUI], 200, [{ id: 2 }, { id: 3 }]],
["GET", "/api/contacts/2", { ...MINA, deleted: true }],
["GET", "/api/contacts/3", { ...RUI, deleted: true }],
];
/** Live contacts that omit `deleted`, one deleted and read back only with a query showing it marked, then a list without it. */
export const OMITTED_FLAG_ROWS: readonly TimedCaptureRow[] = (() => {
const live = (entity: Entity): Entity => {
const { deleted: _deleted, ...rest } = entity;
return rest;
};
const [ada, mina, rui] = [live(ADA), live(MINA), live(RUI)];
return [
["GET", "/api/contacts?maxSize=20&offset=0", page([ada, mina, rui])],
["GET", "/api/contacts?maxSize=2&offset=0", page([ada, mina])],
["GET", "/api/contacts/1", ada],
["GET", "/api/contacts/2", mina],
["DELETE", "/api/contacts/2", true],
["GET", "/api/contacts/2?_=1761520000", { ...mina, deleted: true }],
["GET", "/api/contacts?maxSize=50&offset=0", page([ada, rui])],
];
})();
/** The same deletes read back only with a query, as a client that adds a cache-busting parameter does. */
export const SOFT_DELETED_QUERY_ROWS: readonly TimedCaptureRow[] = [
["GET", "/api/contacts?maxSize=20&offset=0", page([ADA, MINA, RUI])],
["GET", "/api/contacts/1", ADA],
["GET", "/api/contacts/2", MINA],
["GET", "/api/contacts/3", RUI],
["DELETE", "/api/contacts/2", true],
["GET", "/api/contacts/2?_=1761520000", { ...MINA, deleted: true }],
["DELETE", "/api/contacts/3", true],
["GET", "/api/contacts/3?_=1761520001", { ...RUI, deleted: true }],
];
/** A held contact read back marked deleted though no delete of it was recorded, then a list without it after another delete. */
export const GHOST_DELETED_ROWS: readonly TimedCaptureRow[] = [
["GET", "/api/contacts?maxSize=20&offset=0", page([ADA, MINA, RUI])],
["GET", "/api/contacts?maxSize=2&offset=0", page([ADA, MINA])],
["GET", "/api/contacts/1", ADA],
["GET", "/api/contacts/2", MINA],
["GET", "/api/contacts/3", RUI],
["DELETE", "/api/contacts/3", true],
["GET", "/api/contacts/2", { ...MINA, deleted: true }],
["GET", "/api/contacts?maxSize=50&offset=0", page([ADA])],
];
/** Contacts deleted, then listed with a page size named `maxSize` other than the initial list's. */
export const MAX_SIZE_ROWS: readonly TimedCaptureRow[] = [
["GET", "/api/contacts?maxSize=20&offset=0", page([ADA, MINA, RUI])],
["GET", "/api/contacts?maxSize=2&offset=0", page([ADA, MINA])],
["GET", "/api/contacts/1", ADA],
["DELETE", "/api/contacts/2", true],
["GET", "/api/contacts?maxSize=50&offset=0", page([ADA, RUI])],
["DELETE", "/api/contacts/3", true],
["GET", "/api/contacts?maxSize=50&offset=0", page([ADA])],
];
const task = (id: number, title: string, extra: Entity = {}): Entity => ({
id,
title,
done: false,
...extra,
});
/** Its subscription: shown only on tasks created while recording, as Vikunja subscribes their creator. */
const subscribed = (id: number): Entity => ({
subscription: { id: 100 + id, entity: "task", entity_id: id },
});
/**
* Seeded tasks without a `subscription`, created tasks whose item reads show one, and updates of the created tasks,
* whose answers show it too.
*/
export const LATER_FIELD_ROWS: readonly TimedCaptureRow[] = (() => {
const seed = task(1, "Trim the wicks");
const first = task(2, "Order lamp oil");
const second = task(3, "Paint the rail");
const created = (entity: Entity) => ({
...entity,
...subscribed(Number(entity["id"])),
});
const done = (entity: Entity) => ({ ...created(entity), done: true });
return [
["GET", "/api/tasks", [seed]],
["GET", "/api/tasks/1", seed],
["POST", "/api/tasks", first, 201, { title: "Order lamp oil" }],
["GET", "/api/tasks/2", created(first)],
["GET", "/api/tasks", [seed, first]],
["POST", "/api/tasks", second, 201, { title: "Paint the rail" }],
["GET", "/api/tasks/3", created(second)],
["GET", "/api/tasks", [seed, first, second]],
["PATCH", "/api/tasks/2", done(first), 200, { done: true }],
["GET", "/api/tasks/2", done(first)],
["PATCH", "/api/tasks/3", done(second), 200, { done: true }],
["GET", "/api/tasks/3", done(second)],
[
"GET",
"/api/tasks",
[seed, { ...first, done: true }, { ...second, done: true }],
],
];
})();
/** The same seeded and created tasks, then one bulk update marking both created tasks done, whose answer shows their subscriptions. */
export const LATER_BULK_ROWS: readonly TimedCaptureRow[] = (() => {
const seed = task(1, "Trim the wicks");
const [first, second] = [
task(2, "Order lamp oil"),
task(3, "Paint the rail"),
];
const created = (entity: Entity) => ({
...entity,
...subscribed(Number(entity["id"])),
});
const done = (entity: Entity) => ({ ...created(entity), done: true });
return [
["GET", "/api/tasks", [seed]],
["GET", "/api/tasks/1", seed],
["POST", "/api/tasks", first, 201, { title: "Order lamp oil" }],
["GET", "/api/tasks/2", created(first)],
["POST", "/api/tasks", second, 201, { title: "Paint the rail" }],
["GET", "/api/tasks/3", created(second)],
["GET", "/api/tasks", [seed, first, second]],
[
"PATCH",
"/api/tasks",
[done(first), done(second)],
200,
[
{ id: 2, done: true },
{ id: 3, done: true },
],
],
["GET", "/api/tasks/2", done(first)],
["GET", "/api/tasks/3", done(second)],
[
"GET",
"/api/tasks",
[seed, { ...first, done: true }, { ...second, done: true }],
],
];
})();
/** A recorded bulk update of a created task and a seeded one, whose answer shows the subscription on the created task only. */
export const LATER_MIXED_BULK_ROWS: readonly TimedCaptureRow[] = (() => {
const seed = task(1, "Trim the wicks");
const first = task(2, "Order lamp oil");
const created = { ...first, ...subscribed(2) };
const done = { ...created, done: true };
const seedDone = { ...seed, done: true };
return [
["GET", "/api/tasks", [seed]],
["GET", "/api/tasks/1", seed],
["POST", "/api/tasks", first, 201, { title: "Order lamp oil" }],
["GET", "/api/tasks/2", created],
["GET", "/api/tasks", [seed, first]],
[
"PATCH",
"/api/tasks",
[done, seedDone],
200,
[
{ id: 2, done: true },
{ id: 1, done: true },
],
],
["GET", "/api/tasks/2", done],
["GET", "/api/tasks/1", seedDone],
["GET", "/api/tasks", [seedDone, { ...first, done: true }]],
];
})();