morluto
690fc51854
Retain absent or invalid Runtime timestamps as null and mark console event coverage incomplete. Preserve observed finite timestamps, including zero, and document the epoch-millisecond clock. BREAKING CHANGE: console event timestamps may now be null when the protocol does not provide a finite number. Refs #5656
69 lines
2.0 KiB
TypeScript
69 lines
2.0 KiB
TypeScript
import { expect, it } from "vitest";
|
|
|
|
import { CdpCaptureEvents } from "./CdpCaptureEvents.js";
|
|
import { inspectWebPageInputSchema } from "../domain/browserObservation.js";
|
|
import { webPageInspectionSchema } from "../domain/browserObservationSchemas.js";
|
|
|
|
const origin = "http://127.0.0.1:43127";
|
|
|
|
const captureWithConsoleTimestamp = (timestamp: unknown): CdpCaptureEvents => {
|
|
const capture = new CdpCaptureEvents(
|
|
inspectWebPageInputSchema.parse({
|
|
cdp_endpoint: origin,
|
|
allowed_origins: [origin],
|
|
target_id: "allowed-page",
|
|
}),
|
|
new Set([origin]),
|
|
);
|
|
const params: Record<string, unknown> = {
|
|
type: "log",
|
|
args: [],
|
|
stackTrace: {
|
|
callFrames: [{ url: `${origin}/app.js`, lineNumber: 0, columnNumber: 0 }],
|
|
},
|
|
};
|
|
if (timestamp !== undefined) params.timestamp = timestamp;
|
|
capture.ingest({ method: "Runtime.consoleAPICalled", params });
|
|
return capture;
|
|
};
|
|
|
|
it.each([
|
|
["an omitted timestamp", undefined],
|
|
["a non-finite timestamp", Number.NaN],
|
|
["a string timestamp", "123"],
|
|
["an explicit null timestamp", null],
|
|
])(
|
|
"retains %s as unknown and marks console coverage invalid",
|
|
(_label, timestamp) => {
|
|
const capture = captureWithConsoleTimestamp(timestamp);
|
|
const event = capture.console[0];
|
|
|
|
expect(event?.timestamp).toBeNull();
|
|
expect(capture.completeness.snapshot().excluded).toContainEqual({
|
|
section: "console_events",
|
|
reason: "invalid_protocol_value",
|
|
count: 1,
|
|
});
|
|
expect(
|
|
webPageInspectionSchema.shape.console.shape.events.element.safeParse(
|
|
event,
|
|
).success,
|
|
).toBe(true);
|
|
},
|
|
);
|
|
|
|
it.each([
|
|
["Unix epoch", 0],
|
|
["pre-epoch", -1],
|
|
])("preserves a finite %s console timestamp", (_label, timestamp) => {
|
|
const capture = captureWithConsoleTimestamp(timestamp);
|
|
|
|
expect(capture.console[0]?.timestamp).toBe(timestamp);
|
|
expect(capture.completeness.snapshot().excluded).not.toContainEqual(
|
|
expect.objectContaining({
|
|
section: "console_events",
|
|
reason: "invalid_protocol_value",
|
|
}),
|
|
);
|
|
});
|