* fix(browser): name web-bundle budgets and recover web deadlines Name the existing heap, per-script, and total web-bundle phases, and reject a per-script deadline above the total. Promote capture, CDP command, source-map decode, and source-map fetch deadlines at today's defaults. Name DevTools timeoutMs, and state that discovery, cleanup grace, byte budgets, and Electron hook retention have no runtime override. Refs #5910 Co-authored-by: morluto <[email protected]> * fix(browser): apply selected web deadlines to the owning phase Keep HTTP and browser-socket discovery on the fixed discovery deadline so a short command_timeout_ms starts at the handshake. Apply scenario command_timeout_ms to launch startup and the primary connect session, and keep service-worker restoration on the fixed 5000 ms grace. Omit command_timeout_ms from recovery text when the operation does not accept it. Co-authored-by: morluto <[email protected]> * fix(browser): retain scenario commands that finish after their deadline A timed-out scenario command stays owned so cleanup can close a late browser or context and restore a mutation that lands after the deadline. Child storage replies use that deadline, scenario recovery names command_timeout_ms in the capture JSON, and the session test connection implements beginCleanupGrace. Co-authored-by: morluto <[email protected]> * fix(browser): keep child command timeouts as the public failure A nested command such as Page.enable that is delivered but never answered was stored as protocol_error, hiding the command name, selected deadline, and recovery. Store the typed timeout and assert that public error. Co-authored-by: morluto <[email protected]> * fix(browser): keep runtime cleanup on the fixed grace Switch runtime restoration to the cleanup grace before the first send so a short command_timeout_ms cannot fail an otherwise successful observation. Stop advertising command_timeout_ms on list_browser_targets, which never bounds a post-discovery command. Co-authored-by: morluto <[email protected]> * test(browser): prove a short command deadline cannot fail runtime cleanup Drive restoration through the runtime fixture. A cleanup command that outlives command_timeout_ms still succeeds, and a stalled restoration names the fixed 5000 ms grace. Co-authored-by: morluto <[email protected]> * fix(browser): name the effective source-map decode deadline codecBudgetLimitation reported a fixed 20-second deadline after a caller selected decode_timeout_ms. Result and Evidence limitations now name that effective millisecond deadline. Co-authored-by: morluto <[email protected]> * fix(browser): separate handshake and target-attach deadlines A browser-level Target.attachToTarget no longer shares the WebSocket handshake budget. Blocked service-worker attachment keeps discovery on its fixed deadline and applies command_timeout_ms to the later handshake and attach. Co-authored-by: morluto <[email protected]> * fix(browser): name the web-bundle resource each runtime exhausts Bun ignores the V8 old-space flag. A Windows Job reports the process commit limit, and other Bun hosts no longer suggest raising max_heap_mb. Co-authored-by: morluto <[email protected]> * fix(browser): cite the browser-socket discovery message budget WebSocket discovery enforces the 64 MiB protocol budget. Timeout recovery no longer advertises the 8 MiB HTTP document budget. Co-authored-by: morluto <[email protected]> * fix(browser): bound the blocked service-worker check before discovery The first registration check has its own fixed 10s deadline. Discovery, handshake, and Target.attachToTarget stay on their separate deadlines. Co-authored-by: morluto <[email protected]> * fix(browser): name the operand that stopped web-bundle admission Host heap pressure no longer claims the fixed result budget is exhausted. A Windows Bun allocation before the commit limit still names that limit. Co-authored-by: morluto <[email protected]> --------- Co-authored-by: Cursor Agent <[email protected]> Co-authored-by: morluto <[email protected]>
232 lines
7.6 KiB
TypeScript
232 lines
7.6 KiB
TypeScript
import type { ProviderIdentity } from "./AnalysisProvider.js";
|
|
import {
|
|
createEvidence,
|
|
type Evidence,
|
|
type EvidenceObservation,
|
|
} from "../domain/evidence.js";
|
|
import { jsonValueSchema } from "../domain/jsonValue.js";
|
|
import { sanitizeBrowserUrl } from "../domain/browserObservation.js";
|
|
import type {
|
|
InspectWebPageInput,
|
|
ListBrowserTargetsInput,
|
|
} from "../domain/browserObservation.js";
|
|
import type {
|
|
BrowserTargetList,
|
|
WebPageInspection,
|
|
} from "../domain/browserObservationSchemas.js";
|
|
import type {
|
|
AnalyzeWebBundleInput,
|
|
WebBundleAnalysis,
|
|
} from "../domain/webBundleAnalysis.js";
|
|
import type {
|
|
ObserveWebSessionInput,
|
|
WebObservationSession,
|
|
} from "../domain/browserSession.js";
|
|
import type {
|
|
DiscoverWebMcpToolsInput,
|
|
WebMcpDiscovery,
|
|
} from "../domain/webMcpDiscovery.js";
|
|
import type {
|
|
BrowserCaptureComparison,
|
|
BrowserCaptureComparisonInput,
|
|
} from "../domain/browserCaptureComparison.js";
|
|
import { commitBrowserScenarioNormalization } from "../domain/browserScenarioNormalization.js";
|
|
import type {
|
|
CaptureWebScreenshotInput,
|
|
CompareWebScreenshotsInput,
|
|
WebScreenshot,
|
|
WebScreenshotDiff,
|
|
} from "../domain/webScreenshot.js";
|
|
|
|
type BrowserEvidenceInput =
|
|
| ListBrowserTargetsInput
|
|
| InspectWebPageInput
|
|
| AnalyzeWebBundleInput
|
|
| ObserveWebSessionInput
|
|
| DiscoverWebMcpToolsInput
|
|
| BrowserCaptureComparisonInput
|
|
| CaptureWebScreenshotInput
|
|
| CompareWebScreenshotsInput;
|
|
type BrowserEvidenceResult =
|
|
| BrowserTargetList
|
|
| WebPageInspection
|
|
| WebBundleAnalysis
|
|
| WebObservationSession
|
|
| WebMcpDiscovery
|
|
| BrowserCaptureComparison
|
|
| WebScreenshot
|
|
| WebScreenshotDiff;
|
|
type BrowserEvidenceOperation =
|
|
| "list_browser_targets"
|
|
| "inspect_web_page"
|
|
| "analyze_web_bundle"
|
|
| "observe_web_session"
|
|
| "discover_webmcp_tools"
|
|
| "compare_web_captures"
|
|
| "capture_web_screenshot"
|
|
| "compare_web_screenshots";
|
|
|
|
/** Create Evidence for one request-scoped external browser observation. */
|
|
export const createBrowserEvidence = (
|
|
operation: BrowserEvidenceOperation,
|
|
input: BrowserEvidenceInput,
|
|
result: BrowserEvidenceResult,
|
|
provider: ProviderIdentity,
|
|
): Evidence =>
|
|
createEvidence(undefined, provider, {
|
|
predicateType: browserPredicate(operation),
|
|
operation,
|
|
parameters: browserParameters(input, result),
|
|
result: jsonValueSchema.parse(result),
|
|
confidence: "observed",
|
|
authority: "external-service",
|
|
environment:
|
|
"browser" in result
|
|
? {
|
|
id: `${result.browser.product}@${result.browser.revision}`,
|
|
platform: "unknown",
|
|
architecture: "unknown",
|
|
isolation: "none",
|
|
}
|
|
: null,
|
|
limitations: [
|
|
...result.limitations,
|
|
...("browser" in result
|
|
? ["Browser host platform and architecture were not observed."]
|
|
: []),
|
|
],
|
|
});
|
|
|
|
const browserParameters = (
|
|
input: BrowserEvidenceInput,
|
|
result: BrowserEvidenceResult,
|
|
): EvidenceObservation["parameters"] => {
|
|
if (!("cdp_endpoint" in input)) {
|
|
if ("before_scenario" in input)
|
|
return {
|
|
comparison_kind: "browser_scenario",
|
|
before_browser: input.before_scenario.browser,
|
|
after_browser: input.after_scenario.browser,
|
|
before_start_origin: input.before_scenario.scenario.start_origin,
|
|
after_start_origin: input.after_scenario.scenario.start_origin,
|
|
normalization_sha256: commitBrowserScenarioNormalization(
|
|
input.normalization,
|
|
).sha256,
|
|
};
|
|
if ("inspection" in input.before && "inspection" in input.after)
|
|
return {
|
|
before_target_id: input.before.inspection.target.target_id,
|
|
before_capture_ended_at:
|
|
input.before.inspection.capture_window.ended_at,
|
|
after_target_id: input.after.inspection.target.target_id,
|
|
after_capture_ended_at: input.after.inspection.capture_window.ended_at,
|
|
};
|
|
if (isScreenshotComparison(input))
|
|
return {
|
|
before_artifact_sha256: input.before.sha256,
|
|
after_artifact_sha256: input.after.sha256,
|
|
channel_threshold: input.channel_threshold,
|
|
};
|
|
throw new Error("Browser comparison input did not match a comparison type");
|
|
}
|
|
const observedOrigin = browserResultTargetOrigin(result);
|
|
const scope = {
|
|
cdp_endpoint: input.cdp_endpoint.recorded,
|
|
allowed_origins:
|
|
input.allowed_origins.length > 0
|
|
? input.allowed_origins
|
|
: "target_id" in input && observedOrigin !== undefined
|
|
? [observedOrigin]
|
|
: [],
|
|
...("command_timeout_ms" in input && input.command_timeout_ms !== undefined
|
|
? { command_timeout_ms: input.command_timeout_ms }
|
|
: {}),
|
|
};
|
|
if (!("target_id" in input)) return scope;
|
|
return {
|
|
...scope,
|
|
target_id: input.target_id,
|
|
...("observation_ms" in input
|
|
? { observation_ms: input.observation_ms }
|
|
: {}),
|
|
...("include_accessibility_text" in input
|
|
? {
|
|
include_accessibility_text: input.include_accessibility_text,
|
|
include_console_text: input.include_console_text,
|
|
include_json_body_shapes: input.include_json_body_shapes,
|
|
include_websocket_shapes: input.include_websocket_shapes,
|
|
include_storage_keys: input.include_storage_keys,
|
|
include_storage_fingerprints: input.include_storage_fingerprints,
|
|
...("include_script_sources" in input
|
|
? { include_script_sources: input.include_script_sources }
|
|
: {}),
|
|
}
|
|
: {}),
|
|
...("fetch_source_maps" in input
|
|
? {
|
|
fetch_source_maps: input.fetch_source_maps,
|
|
...(input.max_heap_mb === undefined
|
|
? {}
|
|
: { max_heap_mb: input.max_heap_mb }),
|
|
...(input.analysis_timeout_ms === undefined
|
|
? {}
|
|
: { analysis_timeout_ms: input.analysis_timeout_ms }),
|
|
...(input.total_analysis_timeout_ms === undefined
|
|
? {}
|
|
: { total_analysis_timeout_ms: input.total_analysis_timeout_ms }),
|
|
...(input.source_map_fetch_timeout_ms === undefined
|
|
? {}
|
|
: {
|
|
source_map_fetch_timeout_ms: input.source_map_fetch_timeout_ms,
|
|
}),
|
|
}
|
|
: {}),
|
|
};
|
|
};
|
|
|
|
const browserResultTargetOrigin = (
|
|
result: BrowserEvidenceResult,
|
|
): string | undefined => {
|
|
if (
|
|
"inspection" in result &&
|
|
typeof result.inspection === "object" &&
|
|
result.inspection !== null &&
|
|
"target" in result.inspection &&
|
|
typeof result.inspection.target === "object" &&
|
|
result.inspection.target !== null &&
|
|
"origin" in result.inspection.target &&
|
|
typeof result.inspection.target.origin === "string"
|
|
)
|
|
return result.inspection.target.origin;
|
|
if (!("target" in result)) return undefined;
|
|
if ("origin" in result.target) return result.target.origin;
|
|
if ("initial_url" in result.target)
|
|
return sanitizeBrowserUrl(result.target.initial_url).origin ?? undefined;
|
|
return undefined;
|
|
};
|
|
|
|
const isScreenshotComparison = (
|
|
input: BrowserEvidenceInput,
|
|
): input is CompareWebScreenshotsInput => "channel_threshold" in input;
|
|
|
|
const browserPredicate = (operation: BrowserEvidenceOperation): string => {
|
|
switch (operation) {
|
|
case "list_browser_targets":
|
|
return "rea.browser-target-list";
|
|
case "inspect_web_page":
|
|
return "rea.web-page-inspection";
|
|
case "analyze_web_bundle":
|
|
return "rea.web-bundle-analysis";
|
|
case "observe_web_session":
|
|
return "rea.web-observation-session";
|
|
case "discover_webmcp_tools":
|
|
return "rea.webmcp-discovery";
|
|
case "compare_web_captures":
|
|
return "rea.web-capture-diff";
|
|
case "capture_web_screenshot":
|
|
return "rea.web-screenshot";
|
|
case "compare_web_screenshots":
|
|
return "rea.web-screenshot-diff";
|
|
}
|
|
};
|